refactor: using slices.Contains to simplify the code #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
approved these changes
Jan 16, 2025
|
@Shaptic Hello, I have rebased the latest code and resolved the conflicts. Please review it again. |
Shaptic
requested changes
Apr 3, 2025
refactor: using slices.Contains to simplify the code Signed-off-by: zhoufanjin <[email protected]>
Except for the test case related to the database connection timeout, all others have passed. Please review again. |
Shaptic
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
using slices.Contains to simplify the code
Why
This is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.
Known limitations
N