Remove support for storing ledger entries in local db #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urvisavla
force-pushed
the
drop-ledgerentries
branch
from
a03a40e to
3fdd4d8
Compare
urvisavla
force-pushed
the
drop-ledgerentries
branch
from
3fdd4d8 to
39ef7c4
Compare
2opremio
reviewed
Apr 24, 2025
Comment on lines
7
to
11
| type LedgerKeyAndEntry struct { | ||
| Key xdr.LedgerKey | ||
| Entry xdr.LedgerEntry | ||
| LiveUntilLedgerSeq *uint32 // optional live-until ledger seq, when applicable. | ||
| } |
There was a problem hiding this comment.
It may be more appropriate to have this in the ledgerentries package
urvisavla
commented
Apr 24, 2025
| @@ -211,11 +209,6 @@ func (s *Service) fillEntriesFromCheckpoint(ctx context.Context, archive history | |||
| ctx, cancel = context.WithTimeout(ctx, s.timeout) | |||
| defer cancel() | |||
|
|
|||
| reader, err := ingest.NewCheckpointChangeReader(ctx, archive, checkpointLedger) | |||
There was a problem hiding this comment.
Since we're no longer reading changes, can we remove fillEntriesFromCheckpoint and simplify maybeFillEntriesFromCheckpoint?
|
I was discussing stellar/js-stellar-sdk#1165 recently, and this feature would require processing ledger entries 🙈 I don't think we should keep it, but I just wanted to note it for visibility - we can always revert this change in a simpler form down the line if this feature request comes to fruition. |
urvisavla
force-pushed
the
drop-ledgerentries
branch
from
eedf4ee to
c05b84d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
[TODO: Short statement about what is changing.]
Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]