Skip to content

Comments

#507: validate no memo on tx for simulateTransaction requests#588

Merged
sreuland merged 8 commits intostellar:mainfrom
sreuland:no_memo
Jan 15, 2026
Merged

#507: validate no memo on tx for simulateTransaction requests#588
sreuland merged 8 commits intostellar:mainfrom
sreuland:no_memo

Conversation

@sreuland
Copy link
Contributor

@sreuland sreuland commented Jan 9, 2026

What

add rpc request validation for no memo on tx for simulateTransaction request.

Why

  • memo existence on tx for simulateTransaction will be rejected by core, so rpc can pre-validate the same and avoid sending the sim to core at all.
  • fixed unrelated issue with e2e not passing.

Closes: #507

Known limitations

@sreuland sreuland merged commit 390d8f3 into stellar:main Jan 15, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Throw an error when simulateTransaction input has memo

2 participants