Fix BeforeJSON/AfterJSON swap in AddLedgerEntryChangeJSON#603
Merged
Conversation
diff.After was incorrectly assigned to l.BeforeJSON instead of l.AfterJSON, causing JSON-format simulation responses to return the post-transaction state in the before field and a null after field for updated ledger entries. The XDR path was correct. Also update the test to use distinct Before/After data for the update case and assert both fields directly, so this class of bug is caught. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Fixes JSON-format simulation state change responses where AfterJSON was accidentally written into BeforeJSON, leading to swapped/null fields for updated ledger entries (while XDR output remained correct).
Changes:
- Correct
AddLedgerEntryChangeJSONto assigndiff.Afterintol.AfterJSON(notl.BeforeJSON). - Strengthen
TestLedgerEntryChangeby using distinct before/after ledger entry data for updates and assertingBeforeJSON/AfterJSONexplicitly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/stellar-rpc/internal/methods/simulate_transaction.go | Fixes JSON field assignment for post-state (AfterJSON) in ledger entry changes. |
| cmd/stellar-rpc/internal/methods/simulate_transaction_test.go | Updates tests to catch Before/After JSON swaps by asserting distinct expected values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
leighmcculloch
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
After was incorrectly assigned to l.BeforeJSON instead of l.AfterJSON, causing JSON-format simulation responses to return the post-transaction state in the before field and a null after field for updated ledger entries. The XDR path was correct.
Also update the test to use distinct Before/After data for the update case and assert both fields directly, so this class of bug is caught.
Known limitations
[N/A]