Conversation
Add SC_ADDRESS_TYPE_MUXED_CONTRACT arm and MuxedContract struct to SCAddress, gated behind #ifdef CAP_0084_MUXED_CONTRACT, mirroring the existing MuxedEd25519Account muxed-account pattern. Appears only in the `next` branch until core bumps the max supported protocol to 28. CAP-0084 (Muxed Contract Addresses): stellar/stellar-protocol#1968
Contributor
Author
|
Downstream: stellar/rs-stellar-xdr#549 regenerates the Rust codec against this PR's head (7b56181), gated behind |
Contributor
Author
|
Downstream (Protocol 28 / CAP-0084): go-stellar-sdk stellar/go-stellar-sdk#5960 pins this commit ( |
This was referenced Jun 27, 2026
Contributor
Author
|
Closing — this stack will be regenerated from scratch by the automated protocol-release flow. |
sisuresh
added a commit
to sisuresh/rs-soroban-env
that referenced
this pull request
Jul 21, 2026
Pin stellar-xdr to rs-stellar-xdr#549 (CAP-0084, fork rev 7b46a60d, crate v28.0.0). Gate all CAP-0084 host code and tests on a dedicated cap_0084_muxed_contract cargo feature (forwarding to next for the proto-28 meta and to stellar-xdr/cap_0084_muxed_contract for the XDR variant), NOT the umbrella next, so the CAP can be pulled pre-release independently. Route ScAddress::MuxedContract through the existing MuxedAddressObject vehicle; SAC transfer de-muxes; mint is cfg-split via a single method with a cfg'd MintDestination alias. Muxed addresses stay prohibited as storage keys. No new host functions; no env version bump (protocol 28 already reported under next). TEMP: deny.toml allows the sisuresh git source for the SPIKE pin. Upstream: stellar/rs-stellar-xdr#549 -> stellar/stellar-xdr#306
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
SC_ADDRESS_TYPE_MUXED_CONTRACTenum arm +MuxedContract { uint64 id; ContractID contractId; }struct +SCAddressunion arm toStellar-contract.x, all gated behind#ifdef CAP_0084_MUXED_CONTRACT, mirroring the existingMuxedEd25519Accountmuxed-account pattern.nextbranch (built--all-features) and stay out ofcurruntil core bumps max protocol to 28.curr/nextregenerate automatically on merge — not edited here.Flag-token contract (downstream)
This repo is the root of the chain — no upstream. The ifdef token
CAP_0084_MUXED_CONTRACTis the verbatim contract for every downstream:cap_0084_muxed_contractXDR_FEATURES/xfile preprocess --features(go-stellar-sdk / js-stellar-base):CAP_0084_MUXED_CONTRACTA mismatched/truncated token silently strips the new types downstream.
Verification
Local
stellar-xdr xfile preprocess: arm absent with no features (curr); all three arms present and file parses with--features CAP_0084_MUXED_CONTRACT.Deferred
CAP-0084: stellar/stellar-protocol#1968