Skip to content

Make closeTimeMs the full close time in milliseconds #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SirTyson merged 1 commit into from
Aug 28, 2026
Merged

Make closeTimeMs the full close time in milliseconds #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Stellar-ledger.x
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,13 @@ struct StellarValue
case STELLAR_VALUE_SIGNED_MS:
struct
{
uint32 closeTimeMs; // millisecond component of closeTime, [0, 999]
TimePointMilliseconds closeTimeMs; // closeTime == closeTimeMs / 1000
LedgerCloseValueSignature lcValueSignature;
} signedMsValue;
case STELLAR_VALUE_EMPTY_TX_SET_MS:
struct
{
uint32 closeTimeMs; // millisecond component of closeTime, [0, 999]
TimePointMilliseconds closeTimeMs; // closeTime == closeTimeMs / 1000
Hash txSetHash;
Hash previousLedgerHash;
uint32 previousLedgerVersion;
Expand Down
4 changes: 4 additions & 0 deletions Stellar-types.x
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ typedef hyper int64;

typedef uint64 TimePoint;
typedef uint64 Duration;
#ifdef MS_CLOSE_TIME
// Milliseconds since the Unix epoch. TimePoint is whole seconds.
typedef uint64 TimePointMilliseconds;
#endif // MS_CLOSE_TIME

// An ExtensionPoint is always marshaled as a 32-bit 0 value. At a
// later point, it can be replaced by a different union so as to
Expand Down
Loading