Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions @stellar/typescript-wallet-sdk/src/walletSdk/Uri/sep7Parser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -163,13 +163,15 @@ export const sep7ReplacementsFromString = (
}

const [txrepString, hintsString] = replacements.split(HINT_DELIMITER);
const hintsList = hintsString.split(LIST_DELIMITER);

const hintsMap: { [id: string]: string } = {};

hintsList
.map((item) => item.split(ID_DELIMITER))
.forEach(([id, hint]) => (hintsMap[id] = hint));
if (hintsString) {
const hintsList = hintsString.split(LIST_DELIMITER);
hintsList
.map((item) => item.split(ID_DELIMITER))
.forEach(([id, hint]) => (hintsMap[id] = hint));
}

const txrepList = txrepString.split(LIST_DELIMITER);

Expand Down
42 changes: 42 additions & 0 deletions @stellar/typescript-wallet-sdk/test/sep7.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -798,6 +798,48 @@ describe("sep7Parser", () => {
);
});

it("sep7ReplacementsFromString() handles replace string without hints (no ';' delimiter)", () => {
const str = "sourceAccount:X,operations[0].sourceAccount:Y";
const replacements = sep7ReplacementsFromString(str);

expect(replacements.length).toBe(2);

expect(replacements[0].id).toBe("X");
expect(replacements[0].path).toBe("sourceAccount");
expect(replacements[0].hint).toBeUndefined();

expect(replacements[1].id).toBe("Y");
expect(replacements[1].path).toBe("operations[0].sourceAccount");
expect(replacements[1].hint).toBeUndefined();
});

it("sep7ReplacementsFromString() handles single replacement without hints", () => {
const str = "sourceAccount:X";
const replacements = sep7ReplacementsFromString(str);

expect(replacements.length).toBe(1);
expect(replacements[0].id).toBe("X");
expect(replacements[0].path).toBe("sourceAccount");
expect(replacements[0].hint).toBeUndefined();
});

it("sep7ReplacementsFromString() returns empty array for undefined/empty input", () => {
expect(sep7ReplacementsFromString(undefined)).toEqual([]);
expect(sep7ReplacementsFromString("")).toEqual([]);
});

it("Sep7Tx.getReplacements() does not crash on replace param missing hints", () => {
const uri = new Sep7Tx(
`web+stellar:tx?xdr=test&replace=${encodeURIComponent("sourceAccount:X")}`,
);

const replacements = uri.getReplacements();
expect(replacements.length).toBe(1);
expect(replacements[0].id).toBe("X");
expect(replacements[0].path).toBe("sourceAccount");
expect(replacements[0].hint).toBeUndefined();
});

it("sep7ReplacementsToString outputs the right string", () => {
const expected =
"sourceAccount:X,operations[0].sourceAccount:Y,operations[1].destination:Y;X:account from where you want to pay fees,Y:account that needs the trustline and which will receive the new tokens";
Expand Down
Loading