Skip to content

Updates table schema and fixes SQL generation#10

Merged
dpanta94 merged 4 commits into
mainfrom
fix/sql-table-definition-for-dbDelta
Jul 31, 2025
Merged

Updates table schema and fixes SQL generation#10
dpanta94 merged 4 commits into
mainfrom
fix/sql-table-definition-for-dbDelta

Conversation

@dpanta94

Copy link
Copy Markdown
Member

Updates the table schema versions and corrects an issue in the SQL generation for table creation using dbDelta.

  • Addresses a problem where an empty line in the SQL schema definition was causing issues with dbDelta.
  • Updates schema versions in Task_Logs and Tasks tables.

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)

Pre-Submission Checklist

Code Quality

  • PHPStan analysis passes: composer test:analysis
  • PHP compatibility check passes: composer compatibility
  • Coding standards pass: vendor/bin/phpcs
  • All tests pass: slic run wpunit && slic run integration
  • No debug code (var_dump, error_log, etc.) left in production code
  • No commented-out code unless specifically needed for reference

Documentation & Communication

  • Documentation updated for any new features or changed behavior
  • CLAUDE.md updated if changes affect AI assistance context
  • Commit messages follow conventional commits format
  • PR title follows conventional format: [scope]: description

Branch & Conflicts

  • Branch is up to date with target branch (usually main)
  • No merge conflicts exist
  • CHANGELOG.md updated (if applicable)

Testing

Automated Testing

  • New tests have been added for new functionality
  • All existing tests continue to pass
  • Test coverage is maintained or improved

Manual Testing

Test Environment:

  • WordPress version: Latest
  • PHP version: 8.0

Test Steps:

  1. Setup: Activate the plugin.
  2. Steps to Reproduce:
    • Check database table creation.
    • Verify schema version.
  3. Verification: Verify that the tables are created correctly and that schema versions are updated.

Expected Results:
Tables are created without the extra empty line in the SQL definition, and the schema versions are correctly updated.

Actual Results:
Tables are created without the extra empty line in the SQL definition, and the schema versions are correctly updated.

Related Issues

N/A

@dpanta94 dpanta94 self-assigned this Jul 31, 2025
@dpanta94 dpanta94 requested a review from bordoni July 31, 2025 19:00
@dpanta94 dpanta94 added the bug Something isn't working label Jul 31, 2025
Comment thread CHANGELOG.md
@dpanta94 dpanta94 merged commit 55f0ae7 into main Jul 31, 2025
11 checks passed
@dpanta94 dpanta94 deleted the fix/sql-table-definition-for-dbDelta branch July 31, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants