-
Notifications
You must be signed in to change notification settings - Fork 0
Implemented broadcasting for MLXArray #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stemann
wants to merge
15
commits into
master
Choose a base branch
from
feature/broadcasting
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+132
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18 +/- ##
==========================================
+ Coverage 24.46% 26.95% +2.48%
==========================================
Files 8 8
Lines 1206 1243 +37
==========================================
+ Hits 295 335 +40
+ Misses 911 908 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9fcd4c1 to
afc4ebd
Compare
f20bbeb to
776b8d6
Compare
776b8d6 to
3e9c444
Compare
3e9c444 to
2f8f9a1
Compare
Also:
* Added necessary eval of MLX array data in Base.unsafe_convert(::Type{Ptr{T}}, array::MLXArray{T, N})
* Implemented Base.similar for MLXArray.
* Added supported_number_types(::DeviceType = DeviceTypeCPU)
2f8f9a1 to
f455bb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.