Skip to content

fix: process.exit in test env only#12

Merged
christian-bromann merged 1 commit into
stencil-community:mainfrom
davidpett:fix-bundle-close
Nov 6, 2025
Merged

fix: process.exit in test env only#12
christian-bromann merged 1 commit into
stencil-community:mainfrom
davidpett:fix-bundle-close

Conversation

@davidpett

@davidpett davidpett commented Nov 4, 2025

Copy link
Copy Markdown
Collaborator

move process.exit to a conditional that checks if env is test as that is the only place that was hanging. this also cleans up the compiler and removes watch from tests

@davidpett davidpett force-pushed the fix-bundle-close branch 2 times, most recently from 092d40e to 2a58998 Compare November 5, 2025 14:09
@davidpett davidpett marked this pull request as draft November 5, 2025 14:12
@davidpett davidpett changed the title fix: process.exit in writeBundle hook fix: process.exit in test env only Nov 5, 2025
@davidpett davidpett marked this pull request as ready for review November 5, 2025 15:08
@davidpett davidpett mentioned this pull request Nov 5, 2025
@davidpett

Copy link
Copy Markdown
Collaborator Author

@christian-bromann any chance we can get this merged and a new version released?

@christian-bromann christian-bromann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@christian-bromann christian-bromann merged commit 67f9047 into stencil-community:main Nov 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants