-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update rollup to latest #6187
build: update rollup to latest #6187
Conversation
ci broken - not sure why |
what do you think @christian-bromann ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@johnjenkins @christian-bromann |
@a7medm7med thanks for the feedback, mind raising a quick issue? |
@christian-bromann |
What is the current behavior?
Rollup ~2
GitHub Issue Number: N/A
What is the new behavior?
Rollup >4
Documentation
Does this introduce a breaking change?
Testing
Tests continue to pass
Other information
One thing ... Stencil used to use
cutomResolveOptions
within@rollup/plugin-node-resolve"
to route fs to it's in-memory fs. However the rollup plugin removed this ability in version11.0.0
. Initial tests doesn't appear to affect bundle performance - if anything it seems faster.However, there is a new
resolve
hook which perhaps I can explore if necessary