Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update rollup to latest #6187

Merged
merged 6 commits into from
Mar 11, 2025

Conversation

johnjenkins
Copy link
Contributor

@johnjenkins johnjenkins commented Mar 6, 2025

What is the current behavior?

Rollup ~2

GitHub Issue Number: N/A

What is the new behavior?

Rollup >4

Documentation

Does this introduce a breaking change?

  • Yes
  • No

Testing

Tests continue to pass

Other information

One thing ... Stencil used to use cutomResolveOptions within @rollup/plugin-node-resolve" to route fs to it's in-memory fs. However the rollup plugin removed this ability in version 11.0.0. Initial tests doesn't appear to affect bundle performance - if anything it seems faster.

However, there is a new resolve hook which perhaps I can explore if necessary

@johnjenkins johnjenkins requested a review from a team as a code owner March 6, 2025 23:46
@johnjenkins
Copy link
Contributor Author

ci broken - not sure why npm ci isn't installing @rollup/rollup-linux-x64-gnu on the vm

@johnjenkins
Copy link
Contributor Author

what do you think @christian-bromann ?

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@a7medm7med
Copy link

a7medm7med commented Mar 12, 2025

@johnjenkins @christian-bromann
Great work! However, Rollup no longer works with .mts files in our setup, where we use @floating-ui and i18next packages.

@christian-bromann
Copy link
Member

@a7medm7med thanks for the feedback, mind raising a quick issue?

@a7medm7med
Copy link

a7medm7med commented Mar 12, 2025

@christian-bromann
Done #6193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants