Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): add more platform specific optionalDependencies (#6195) #6196

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

hettiger
Copy link
Contributor

@hettiger hettiger commented Mar 12, 2025

This fixes e.g. failing builds on Apple Silicon.

fixes: #6195

What is the current behavior?

GitHub Issue Number: #6195

Build is failing on e.g. Apple Silicon:

stencil build
[59:05.5]  @stencil/core

[ ERROR ]  uncaught cli error: Error: Cannot find module @rollup/rollup-darwin-arm64. npm has a bug related to optional
           dependencies (https://github.com/npm/cli/issues/4828). Please try `npm i` again after removing both
           package-lock.json and node_modules directory.

What is the new behavior?

Build runs just fine on Apple Silicon.

stencil build
[01:31.0]  @stencil/core
[01:31.1]  [LOCAL DEV] v4.28.0-dev.1741780803.d0b8b4a 🎁
[01:31.6]  build, stencil-rollup, prod mode, started ...
[01:31.6]  transpile started ...
[01:32.6]  transpile finished in 975 ms
[01:32.6]  generate custom elements + source maps started ...
[01:32.6]  generate lazy + source maps started ...
[01:32.8]  generate custom elements + source maps finished in 152 ms
[01:32.8]  generate lazy + source maps finished in 223 ms
[01:32.8]  copy started ...
[01:32.8]  copy finished (0 files) in 8 ms
[01:32.9]  build finished in 1.23 s

Documentation

Does this introduce a breaking change?

  • Yes
  • No

Testing

Successfully ran npm run test and tested it in a clean demo project.

Other information

@hettiger hettiger requested a review from a team as a code owner March 12, 2025 12:05
Copy link
Contributor

@johnjenkins johnjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@johnjenkins johnjenkins added this pull request to the merge queue Mar 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 12, 2025
@christian-bromann christian-bromann merged commit e2965e5 into stenciljs:main Mar 12, 2025
732 of 781 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Cannot find module @rollup/rollup-darwin-arm64
3 participants