-
Notifications
You must be signed in to change notification settings - Fork 806
fix(types): correct key name interpolation for ARIA attributes in DOM typings #6244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(types): correct key name interpolation for ARIA attributes in DOM typings #6244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@AlirezaEbrahimkhani it seems like there are 2 tests failing:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind adjusting the tests?
13faf4e
to
dee6b0d
Compare
Thanks for your review. I have fixed it. |
dee6b0d
to
1de19fb
Compare
<h1 ariaLabel={123}>Hello</h1> | ||
<h1 aria-label="123">Hello</h1> | ||
<h1 aria-label={'123'}>Hello</h1> | ||
<h1 aria-label={123}>Hello</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should fail as aria-label
does not expect a number
, however the test seem to pass. The point of the test here is to verify that the compiler here actually points out the type error.
This issue was raised by @duhem-s in a comment on my previous PR (#6221), and I'm addressing it in this one.
What is the current behavior?
GitHub Issue Number: N/A
What is the new behavior?
Documentation
Does this introduce a breaking change?
Testing
Other information