Skip to content

fix(vue): resolve original vue instance #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

christian-bromann
Copy link
Member

Pull request checklist

With see issues with Vue and Nuxt where importing wrapped Vue components fail because the output target imports a different Vue instance than the original Nuxt project. This is an attempt to resolve the issue. However this is still not an optimal solution as it requires additional work to compile the current approach for CJS.

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally for affected output targets
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Server side rendering wrapped Stencil components with the Vue output target resolves into:

500
Cannot read properties of null (reading 'ce')

What is the new behavior?

We import the same Vue module as the users uses for their Nuxt application.

Does this introduce a breaking change?

  • Yes
  • No

Other information

n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant