Skip to content

Conversation

davidpett
Copy link
Contributor

add the setup for basic html source decorator

@christian-bromann
Copy link
Member

@davidpett thanks for raising the PR!

How does this patch differs from the work done in #7. As I understand there are multiple preview setups within Storybook. #7 implements the JSX version and this one the html one. As I mentioned to @dogoku before, it would be nice if we could allow users to choose. I personally don't have a strong opinion here.

@davidpett
Copy link
Contributor Author

@christian-bromann right, this will have the basics and allow easy addition of more languages. I see it as something that @dogoku could build onto by just adding the jsx decorator

@davidpett davidpett force-pushed the dpett/docs-preview-setup branch from 0a59866 to 3e193a5 Compare June 10, 2025 17:37
@dogoku
Copy link
Contributor

dogoku commented Jun 10, 2025

@christian-bromann right, this will have the basics and allow easy addition of more languages. I see it as something that @dogoku could build onto by just adding the jsx decorator

To be fair, I rushed into my PR not considering all the use cases, so I don't mind rebasing my work, given that this PR will fix an immediate problem and create the groundwork to support both language modes.

So you can go ahead with this PR and I will pick up my work over the weekend, as I don't have time to work on this during the week.

@christian-bromann
Copy link
Member

Thanks for your feedback @dogoku I will go ahead and review/merge this then.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann merged commit ca625dc into stenciljs:main Jun 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants