Skip to content

Conversation

dogoku
Copy link
Contributor

@dogoku dogoku commented Jun 6, 2025

  • Run storybook@latest upgrade and fixed a couple of issues
    • the upgrade command only worked for example, since it needs a .storybook/main.ts
    • not sure if its worth adding that to plugin as well, just to get the upgrade tool working
  • Updated plugin deps manually
    • Added storybook@9 as peerDep
    • Removed @storybook/types types are now part of main storybook package
  • Unpinned @stencil/core dependency in example, but didn't upgrade to v4.33 (i'll leave that to maintainers)

- run `storybook@later upgrade` and fixes a couple of issues
- also updated plugin deps to remove @storybook/types
    - types are now part of main storybook package
    - added as peerDep, but it was more for safetey
Comment on lines +3 to +7
onlyBuiltDependencies:
- edgedriver
- esbuild
- geckodriver
- puppeteer
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what those are... pnpm asked me something and i just said yes.
let me know if u want them removed.

@christian-bromann christian-bromann merged commit 3182503 into stenciljs:main Jun 6, 2025
1 check passed
@dogoku dogoku deleted the feat/storybook-v9 branch June 7, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants