fixes for windows-arm64 support#640
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Windows ARM64 handling so the action exits gracefully with a clearer, Windows-specific unsupported-runner message during install and cleanup.
Changes:
- Add
ARM64_WINDOWS_RUNNER_MESSAGEconstant for Windows ARM64 runners. - Use the new message in Windows agent installation (and corresponding compiled
dist/prebundle). - Short-circuit Windows cleanup on ARM64 (and corresponding compiled
dist/postbundle).
Reviewed changes
Copilot reviewed 3 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/install-agent.ts | Switch Windows ARM64 install messaging to a Windows-specific constant. |
| src/common.ts | Introduce a dedicated Windows ARM64 unsupported message constant. |
| src/cleanup.ts | Add an early return for Windows ARM64 during cleanup. |
| dist/pre/index.js | Compiled bundle updates for Windows ARM64 install messaging. |
| dist/post/index.js | Compiled bundle updates for Windows ARM64 cleanup short-circuit. |
| dist/index.js | Compiled bundle adds the new Windows ARM64 message constant. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return; | ||
| } | ||
|
|
||
| if (process.arch === "arm64") { |
There was a problem hiding this comment.
On Windows arm64 you return before writing post_event.json. That breaks the existing “post step already executed” guard, so if the action is used multiple times in the same job the post-step will run (and log) repeatedly. Consider still creating a post-step marker (e.g., write post_event.json after ensuring agentDir exists, or use a marker location independent of C:\agent) before returning.
| if (process.arch === "arm64") { | |
| if (process.arch === "arm64") { | |
| try { | |
| if (!fs.existsSync(agentDir)) { | |
| fs.mkdirSync(agentDir, { recursive: true }); | |
| } | |
| fs.writeFileSync(postEventFile, JSON.stringify({ event: "post" })); | |
| } catch (error) { | |
| console.log( | |
| "warning: failed to write Windows post-step marker:", | |
| (error as any).message || error | |
| ); | |
| } |
No description provided.