Skip to content

fixes for windows-arm64 support#640

Merged
varunsh-coder merged 2 commits intostep-security:rc-36from
h0x0er:jatin/fix-win-arm
Feb 28, 2026
Merged

fixes for windows-arm64 support#640
varunsh-coder merged 2 commits intostep-security:rc-36from
h0x0er:jatin/fix-win-arm

Conversation

@h0x0er
Copy link
Member

@h0x0er h0x0er commented Feb 26, 2026

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Windows ARM64 handling so the action exits gracefully with a clearer, Windows-specific unsupported-runner message during install and cleanup.

Changes:

  • Add ARM64_WINDOWS_RUNNER_MESSAGE constant for Windows ARM64 runners.
  • Use the new message in Windows agent installation (and corresponding compiled dist/pre bundle).
  • Short-circuit Windows cleanup on ARM64 (and corresponding compiled dist/post bundle).

Reviewed changes

Copilot reviewed 3 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/install-agent.ts Switch Windows ARM64 install messaging to a Windows-specific constant.
src/common.ts Introduce a dedicated Windows ARM64 unsupported message constant.
src/cleanup.ts Add an early return for Windows ARM64 during cleanup.
dist/pre/index.js Compiled bundle updates for Windows ARM64 install messaging.
dist/post/index.js Compiled bundle updates for Windows ARM64 cleanup short-circuit.
dist/index.js Compiled bundle adds the new Windows ARM64 message constant.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

return;
}

if (process.arch === "arm64") {
Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Windows arm64 you return before writing post_event.json. That breaks the existing “post step already executed” guard, so if the action is used multiple times in the same job the post-step will run (and log) repeatedly. Consider still creating a post-step marker (e.g., write post_event.json after ensuring agentDir exists, or use a marker location independent of C:\agent) before returning.

Suggested change
if (process.arch === "arm64") {
if (process.arch === "arm64") {
try {
if (!fs.existsSync(agentDir)) {
fs.mkdirSync(agentDir, { recursive: true });
}
fs.writeFileSync(postEventFile, JSON.stringify({ event: "post" }));
} catch (error) {
console.log(
"warning: failed to write Windows post-step marker:",
(error as any).message || error
);
}

Copilot uses AI. Check for mistakes.
@varunsh-coder varunsh-coder changed the base branch from main to rc-36 February 28, 2026 16:05
@varunsh-coder varunsh-coder merged commit ac63a71 into step-security:rc-36 Feb 28, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants