feat: add logging capability to SecureWorkflow#2517
Merged
varunsh-coder merged 1 commit intomainfrom May 10, 2025
Merged
Conversation
Member
varunsh-coder
commented
May 10, 2025
- Add enableLogging query parameter (off by default)
- Log input YAML and query parameters when enabled
- Log processing steps and errors when enabled
- Add final result logging
- Add enableLogging query parameter (off by default) - Log input YAML and query parameters when enabled - Log processing steps and errors when enabled - Add final result logging
Contributor
step-security-bot
left a comment
There was a problem hiding this comment.
Please find StepSecurity AI-CodeWise code comments below.
Code Comments
remediation/workflow/secureworkflow.go
[
{
"Severity": "High",
"Recommendation": "Avoid logging sensitive information",
"Description": "Logging sensitive information such as query parameters and input YAML can expose sensitive data to logs, which can be a security risk.",
"Remediation": "Ensure that only non-sensitive information is logged, and sensitive data is properly sanitized or obfuscated before logging."
},
{
"Severity": "Medium",
"Recommendation": "Avoid logging errors along with sensitive data",
"Description": "Logging errors along with sensitive data can expose critical information to logs, which can potentially lead to security vulnerabilities.",
"Remediation": "Separate error logging from sensitive data logging and ensure that error messages do not contain sensitive information."
}
]Feedback
We appreciate your feedback in helping us improve the service! To provide feedback, please use emojis on this comment. If you find the comments helpful, give them a 👍. If they aren't useful, kindly express that with a 👎. If you have questions or detailed feedback, please create n GitHub issue in StepSecurity/AI-CodeWise.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2517 +/- ##
==========================================
- Coverage 65.95% 64.32% -1.63%
==========================================
Files 17 17
Lines 1818 1864 +46
==========================================
Hits 1199 1199
- Misses 527 563 +36
- Partials 92 102 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ashishkurmi
approved these changes
May 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.