Merged
Conversation
The pci domain may not be 0000, get the full domain:bus:device.function through cudaDeviceGetPCIBusId to concat the pcipath. Signed-off-by: Guangguan Wang <guangguan.wang@linux.alibaba.com>
Backend::Get()->SetDevice(gpu_) after ps::StartPS, but in the function ps::StartPS, when calling GetInterfaceAndIPByCurrentGpu, the gpu id is needed to detect the nearest rdma dev depends the pci topo. Calling cudaGetDevice before Backend::Get()->SetDevice(gpu_), gpu id 0 will returned, which may not be the preferred gpu. So move Backend::Get()->SetDevice(gpu_) into ps::StartPS but before GetInterfaceAndIPByCurrentGpu. Signed-off-by: Guangguan Wang <guangguan.wang@linux.alibaba.com>
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes for StepMesh(not eRDMA specific fixes).