Skip to content

benchmark: fix for pull key#9

Merged
zhouyu-sunny merged 1 commit intostepfun-ai:mainfrom
fengidri:main
Aug 5, 2025
Merged

benchmark: fix for pull key#9
zhouyu-sunny merged 1 commit intostepfun-ai:mainfrom
fengidri:main

Conversation

@fengidri
Copy link
Contributor

@fengidri fengidri commented Aug 5, 2025

When I run the test using bmk_comm_latency_multiserver.py, I encounter the following error if the number of servers is not 1. The issue arises because an error occurs when generating the pull key, resulting in an incorrect key size. This commit fixes the problem.

/usr/include/c++/10/bits/stl_vector.h:1045: std::vector<_Tp, _Alloc>::reference std::vector<_Tp, _Alloc>::operator[](std::vector<_Tp, _Alloc>::size_type) [with _Tp = long unsigned int;
_Alloc = std::allocator;
std::vector<_Tp, _Alloc>::reference = long unsigned int&; std::vector<_Tp, _Alloc>::size_type =
long unsigned int]: Assertion '__builtin_expect(__n < this->size(), true)' failed.

On the other hand, this error message is very inconvenient for pinpointing the issue, so I have added PS_CHECK_EQ() to help quickly identify similar problems.

When I run the test using bmk_comm_latency_multiserver.py, I encounter the
following error if the number of servers is not 1. The issue arises because an
error occurs when generating the pull key, resulting in an incorrect key size.
This commit fixes the problem.

/usr/include/c++/10/bits/stl_vector.h:1045: std::vector<_Tp, _Alloc>::reference
std::vector<_Tp, _Alloc>::operator[](std::vector<_Tp, _Alloc>::size_type) [with _Tp = long unsigned int;
	_Alloc = std::allocator<long unsigned int>;
std::vector<_Tp, _Alloc>::reference = long unsigned int&; std::vector<_Tp, _Alloc>::size_type =
       long unsigned int]: Assertion '__builtin_expect(__n < this->size(), true)' failed.

On the other hand, this error message is very inconvenient for pinpointing the
issue, so I have added PS_CHECK_EQ() to help quickly identify similar problems.

Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
@zhouyu-sunny zhouyu-sunny merged commit 4e76502 into stepfun-ai:main Aug 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants