Skip to content

Add support for inplace_vector #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

20162026
Copy link
Contributor

@20162026 20162026 commented May 5, 2025

@20162026
Copy link
Contributor Author

20162026 commented May 5, 2025

It works, but I'm not sure if it is worthy to be merged becouse:

  1. only json read is implemented ( beve dose not use emplace_back and would require more modifications, didn't check others)
  2. serializing into inplace_vector<char, N> without exceptions is tricky becouse of multiple resize calls
  3. beman::inplace_vector is not fully implemented (e.g. <=> is broken, no proper constexpr handling, init list only works with exceptions enabled, build fails with clang fnoexcept)

@stephenberry
Copy link
Owner

Thanks for making this merge request! I do like the idea of inplace_vector support and this gives a starting point for experimenting with that support. I'll look into them when I get some time. I wouldn't mind merging in a solution that is 90% there and improving it over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants