Add Formatron framework - #5
Open
adrianeboyd wants to merge 3 commits into
Open
Conversation
Reviewer's Guide by SourceryThis pull request introduces the Formatron framework, a new machine learning framework for various NLP tasks. The changes include adding configuration for the Formatron framework in the config.yaml file and implementing the FormatronFramework class in a new file. File-Level Changes
Tips
|
There was a problem hiding this comment.
Hey @adrianeboyd - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider removing the commented-out code for the 'ner_required_fields' task if it's not being used. This will improve code cleanliness and readability.
- The fallback to a regex-based approach for multilabel classification due to issues with Formatron might be worth investigating further. Consider looking into why Formatron isn't handling this case well and potentially contributing a fix upstream.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Contributor
Author
|
Some example results (1 run instead of 10, on an RTX A5000):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Add the FormatronFramework to the project, enabling new tasks like multilabel classification and synthetic data generation with specific model configurations. Update the configuration file to include settings for the new framework.
New Features:
Enhancements: