#118 feat: add File Lifetime #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlexed
reviewed
Sep 5, 2025
| throw new Error(`File ${fileName} not exist`); | ||
| } | ||
| const stats: Stats = await stat(filePath); | ||
| return (stats.birthtime || stats.mtime).getTime(); |
There was a problem hiding this comment.
Почему тут birthtime || mtime?
| allFilesQb.andWhere('(model.fileSize = 0 OR model.fileSize IS NULL)'); | ||
| } | ||
|
|
||
| if (config.unusedFileLifetimeMs) { |
There was a problem hiding this comment.
Давай добавим тут комментарий, где будет пояснено что мы делаем
Comment on lines
+57
to
+59
| fileNameLike?: string, | ||
| ignoredTables?: string[], | ||
| isEmpty?: boolean, |
There was a problem hiding this comment.
Почему тут и в остальных местах ослаблены типы (параметры сделаны необязательными)?
Comment on lines
+212
to
+216
| this.justUploadedTempFileLifetimeMs = custom.justUploadedTempFileLifetimeMs | ||
| || parseInt(process.env.JUST_UPLOADED_TEMP_FILE_LIFETIME_S || '10', 10) * 1000; | ||
|
|
||
| this.justUploadedUnusedFileLifetimeMs = custom.justUploadedUnusedFileLifetimeMs | ||
| || parseInt(process.env.JUST_UPLOADED_UNUSED_FILE_LIFETIME_S || String(24 * 60 * 60), 10) * 1000; |
There was a problem hiding this comment.
Давай дефолтные значения вынесем в константы.
Comment on lines
+17
to
+18
| Sentry.captureException(error); | ||
| return true; |
There was a problem hiding this comment.
Думаю что не совсем корректно будет возвращать true если файла, к примеру, не нашлось, или возникли проблемы с определением его лайфтайма.
Как насчет того чтобы бросать ошибку, а вместе использования ловить ошибку:
try {
if (!(await isFileJustCreated(storage, filePath, currentTimeMs, this.fileConfigService.justUploadedTempFileLifetimeMs))) {
await storage.deleteFile(filePath);
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавил проверку создания временных и неиспользуемых файлов при удаление.