add irrelevant errors method #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProFIT1337
reviewed
Oct 21, 2025
src/ui/form/FieldList/FieldList.tsx
Outdated
| formArrayRemove(context.formId, props.input.name, rowIndex), | ||
| ]; | ||
|
|
||
| const listErrors = _get(reduxFormValues.errors, props.input.name); |
There was a problem hiding this comment.
Уверен, что reduxFormValues всегда существует и не будет ошибки по попытке получить .errors?
Уверен, что во всех случаях в этом объекте по этому пути будет массив, в который ты потом пытаешься пушить?
There was a problem hiding this comment.
Отмена по второму вопросу
There was a problem hiding this comment.
Нет, поставил опционалку
fogarea
reviewed
Oct 21, 2025
| ]; | ||
|
|
||
| const listErrors = _get(reduxFormValues?.errors, props.input.name); | ||
| if (!_isEmpty(listErrors)) { |
There was a problem hiding this comment.
Стоит оставить комментарии, что делает код внутри if
fogarea
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge branch '#862' into 'master'