Let rtlsdr_set_tuner_if_gain return -1 upon error.#21
Open
lcl7 wants to merge 1 commit into
Open
Conversation
Let rtlsdr_set_tuner_if_gain() return -1 when it cannot be set. That was the case when there is no device, no tuner or when the value was invalid, but it returned 0 when the there was no way to set if-gain in the receiver. Now it returns also -1 when there is no set-function for if_gain.
|
This seems useful :) |
paulyc
pushed a commit
to paulyc/librtlsdr
that referenced
this pull request
May 31, 2019
* So @f4exb was right to include the rtl_tcp.h in CMakeLists install. If anyone is making a C program that communicates with rtl_tcp, it will probably use the enums. (See PR steve-m#22 and issue steve-m#21) * Added rtl_tcp.h to CMakeLists install script and moved rtl_tcp.h include to rtl_tcp.c file * Added Eclipse gitignore (for anyone that uses eclipse to compile) * Closes Issue steve-m#21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let rtlsdr_set_tuner_if_gain() return -1 when it cannot be set.
That was the case when there is no device, no tuner or when the
value was invalid, but it returned 0 when the there was no way
to set if-gain for the used receiver.
Now it returns also -1 when there is no set-function for if_gain.
Without this patch, a user interface is not aware that the
specified if_gain has not been set when using a tuner without
a set_if_gain() function.