Skip to content

Fix endless moved redirections, connection leak and others #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix endless moved redirections, connection leak and others #100

wants to merge 5 commits into from

Conversation

orelmaliach
Copy link

  1. Fix weird case where redis connection returns MOVED response to the same node from which the data was fetched- closing the TCP socket resolves the issue.
  2. Fix a potential connection leak in case of node failure or cluster down.
  3. Fix ASK redirection resulting in an extra redirection attempt.
  4. Fix key in case of "eval" or "evalsha" command with 0 keys.
  5. Fix handling of failure to parse ASK signal when it came from a pipeline result.
  6. Refactor, reformat, fix typos.

Or Elmaliach added 3 commits September 16, 2022 01:59
1. Fix weird case where redis connection returns MOVED response to th…
128df18 
…e same node from which the data was fetched. Closing the TCP socket seems to solve the issue.

2. Extract some functions.
3. Reformat.
4. Fix some typos.
1. Fix a potential connection leak in case of node failure or cluster…
d7c7ba8 
… down.

2. Fix ASK redirection resulting in an extra redirection attempt.
3. Fix key in case of "eval" or "evalsha" command, with 0 keys.
4. Fix handling of failure to parse ASK signal when it came from a pipeline result.
5. Refactored some more.
Fix bug missing argument to string.sub
a6781fa
@orelmaliach orelmaliach closed this Oct 2, 2022
@orelmaliach orelmaliach reopened this Oct 2, 2022
Or Elmaliach added 2 commits November 27, 2022 18:51
1. Merge with shuxiao9058: cache slots_info in memory.
1b033c0 
2. Don't trigger refresh_slots in case of error: "too many waiting connect operations".
1. Fix connection leak after merge.
7c6d627 
2. Fix assignment to slots and servers after call to generate_full_slots_cache_info.
3. Remove error logs when first trying to initialize slot cache.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@orelmaliach