extern crate is considered unidiomatic in 2018 rust#104
Open
lamalex wants to merge 6 commits into
Open
Conversation
added 6 commits
July 31, 2020 22:44
Update mod4.rs and related content in 4-modules.md to use 2018 conventions for use declarations.
Update test-json.rs and related content in 4-modules.md to use 2018 conventions for use declarations.
Add json-serde.rs to code samples and and update related content in 4-modules.md to use 2018 conventions for use declarations, and serde 1.0 conventions.
Replace `extern crate` declarations 04-modules.md More Gems section
Replace `extern crate` declarations for simple_error example in 6-error-handling.md Did not update error_chain. error_chain! macro depends on internal macros, and is not easily imported without #[macro_use] extern crate declaration. This should be fixed upstream.
Update code samples in 7-shared-and-networking.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes usage of
extern cratewhere appropriate. There are still a few places whereextern crateis the most reasonable solution due to crates which have not been updated to the current idioms (nom, error_chain).