Skip to content

lsjr39 submission #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

lsjr39 submission #42

wants to merge 4 commits into from

Conversation

Ireneningwang
Copy link

P5.js assignment

@Ireneningwang
Create wave.js
cd86338 
A .js file containing the relevant class definition
@Ireneningwang
Create index.js
9ed3fc3 
A index file
@Ireneningwang
Create index.html
8287254 
A .html file which uses the .js file and demonstrates its use
@Ireneningwang
Update README.md
5c01b1e
@Ireneningwang Ireneningwang changed the title Wave lsjr39 submission Jan 31, 2019
stevenaeola
stevenaeola approved these changes Mar 30, 2019
View reviewed changes
Copy link
Owner

@stevenaeola stevenaeola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put these files in a directory with an informative name

stevenaeola
stevenaeola requested changes Mar 30, 2019
View reviewed changes
Copy link
Owner

@stevenaeola stevenaeola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are not required to make these changes for your university coursework, but if you want your work to be shared with others it needs it be in its own directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenaeola stevenaeola stevenaeola requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ireneningwang @stevenaeola