Skip to content

Fix assets folder #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Lordfirespeed
Copy link
Contributor

Assets folder was missing dist directory for bootstrap and images. Also removes redundant whitespace in index.html

@Dergg
Copy link
Contributor

Dergg commented Nov 21, 2022

Same things that I did in #76

@Lordfirespeed
Copy link
Contributor Author

Same things that I did in #76

It wasn't clear from your PR that it resolved this issue.
It's good practise to split PRs into features and bugfixes; if there are features in your PR that the repo manager doesn't want to integrate, they cannot merge the bugfixes without first asking you to remove the features.

@Dergg
Copy link
Contributor

Dergg commented Nov 22, 2022

Same things that I did in #76

It wasn't clear from your PR that it resolved this issue. It's good practise to split PRs into features and bugfixes; if there are features in your PR that the repo manager doesn't want to integrate, they cannot merge the bugfixes without first asking you to remove the features.

Yeah, I'm still trying to figure out GitHub etiquette. Apologies

@Lordfirespeed
Copy link
Contributor Author

Yeah, I'm still trying to figure out GitHub etiquette. Apologies

That's ok! No need to apologise :) . I really like that your PR is split into lots of smaller commits - that's great practise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants