Skip to content

working with multiple textures, and some more readable examples for shaders#860

Closed
tzukpolinsky wants to merge 7 commits intostevenlovegrove:masterfrom
tzukpolinsky:master
Closed

working with multiple textures, and some more readable examples for shaders#860
tzukpolinsky wants to merge 7 commits intostevenlovegrove:masterfrom
tzukpolinsky:master

Conversation

@tzukpolinsky
Copy link
Contributor

Hello
For an academic project I'm creating in Haifa University, I tried to use the ModelViewer tool to load multiple textures.
In the first attempt, because in geometry_obj the texture names are given using an iterator and in the shader there is only one texture "texture_0", I couldn't use the program as is.

So I attached the texture names to the object names,and in GLDraw changed the structure of the function.

I hope you could integrate it in the repository, because loading and working with several textures is a painful subject across the web.

Thank you in advance
Tzuk Polinsky

@christian-rauch
Copy link
Collaborator

I know this was opened long ago. Is this still relevant?

The PR contains many style and functional changes. If you are still interested in merging the features, can you rebase your PR branch and only commit the functional changes, i.e. remove all style and refactoring changes?

@tzukpolinsky
Copy link
Contributor Author

Hi
i addmit im not in the computer vision field for 2 years now, and i dont have the enviroment to run full tests:)

you want me just to pull my fork and remove the last conflicts and PR again?

sry for the inconvinance.

@christian-rauch
Copy link
Collaborator

I can understand.

It looks to me that this PR has two different features: 1) enable multiple textures, 2) work with multiple windows. If you still want to contribute these changes, I would suggest moving the "multiple windows" commits into a dedicated PR and keep this one for the "multiple textures" features. This way, you can also remove the conflicting commit.

@tzukpolinsky
Copy link
Contributor Author

Done:)
let me know if you need me to do anything else

@christian-rauch
Copy link
Collaborator

Since #993 has been closed, I am also closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants