ci(docs): add workflow_dispatch so the site can be redeployed on demand - #22
Merged
Conversation
Add a workflow_dispatch trigger. The artefact upload step and the deploy job were gated on `github.event_name == 'push'`, so a manual run would have built the site and then deployed nothing; both now exclude pull_request instead of requiring push. Closes #14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
workflow_dispatch:to the Documentation workflow so the site can beredeployed without pushing to
main.The trigger alone would not have been enough. Both the artefact upload step and
the
deployjob were gated ongithub.event_name == 'push', so a manual runwould have built the site and then deployed nothing. Both now read
!= 'pull_request', which admitspushandworkflow_dispatchwhile keepingpull requests build-only.
concurrency.cancel-in-progressis left as-is: it evaluates false forworkflow_dispatch, matching the existingpushbehaviour, so a manual deploywill not be cancelled by a subsequent one.
Why this was needed
After switching GitHub Pages from the legacy branch source to
build_type: workflow, the site kept serving the stale Jekyll deployment andthere was no way to trigger a rebuild — the only route was re-running the
historical merge run for #12.
Verification
push,pull_request,workflow_dispatchifconditions confirmed asgithub.event_name != 'pull_request'workflow_dispatchis read from the default branch
stfc/goldilocks-mlhas the same workflow and the same gap; noted in #14 asworth mirroring.
Closes #14
Written by an agent on behalf of @junwen94.