Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add nequip as a
janus train [architecture]option, where the [architecture] is now a required argument to train. AllArchitecturesother than"mace","mace_mp","mace_off","mace_omol", and"nequip"raise an error.It does work with these inputs inputs.zip
Todo:
janus train nequip.One thing I noticed is that
janus train mace ...will currently output outsidejanus_results, but the way I have it for nequip it goes intojanus_results. What's better? E.g. for mace,Or is that something that is control by the mace
config.yml? For nequip I've had to set it manually so I chose./janus_results.Details
Similar to
mace.cli.run_train.run, nequip has anequip.scripts.train.mainentrypoint - but it uses Hydra to manage configuration here.I've done similar to the current code and used the
mainfunction rather than a subprocess. This means using the Compose API which at least one downsides - thehydra.runtime.output_diris not set, but is required, and we have to manually set the HydraConfig singleton (as far as I've found...).This does mean that we have a match that obtains the runner function and its arguments, seperating out modules to avoid conflicts (mace/nequip in fact is one).