fix(messaging): dismiss stale message overlay before send_message#465
Open
devag7 wants to merge 3 commits into
Open
fix(messaging): dismiss stale message overlay before send_message#465devag7 wants to merge 3 commits into
devag7 wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a proactive cleanup step to send_message to dismiss any lingering LinkedIn messaging overlay before navigating, along with a regression test to enforce the call order.
Changes:
- Call
_dismiss_message_ui()at the start ofLinkedInExtractor.send_message()to prevent UI overlays from intercepting interactions. - Add an async test ensuring dismissal happens before the first navigation in
send_message.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/test_scraping.py | Adds a regression test verifying _dismiss_message_ui() is invoked before navigation in send_message. |
| linkedin_mcp_server/scraping/extractor.py | Ensures send_message dismisses any stale messaging overlay before navigating to the recipient profile. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+4150
to
+4151
| assert calls[0] == "dismiss" | ||
| assert calls[1] == "nav" |
Comment on lines
+3170
to
+3172
| # Clear any floating message overlay from previous tools/calls | ||
| # that might intercept the compose box or block page interactions. | ||
| await self._dismiss_message_ui() |
Contributor
Greptile SummaryThis PR updates
Confidence Score: 5/5This looks safe to merge.
Reviews (3): Last reviewed commit: "test(messaging): use synchronous mock si..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #433. Calls _dismiss_message_ui at the beginning of send_message to prevent stale overlays from causing composer_unavailable.