Skip to content

fix(messaging): dismiss stale message overlay before send_message#465

Open
devag7 wants to merge 3 commits into
stickerdaniel:mainfrom
devag7:fix/433-composer-unavailable-second-call
Open

fix(messaging): dismiss stale message overlay before send_message#465
devag7 wants to merge 3 commits into
stickerdaniel:mainfrom
devag7:fix/433-composer-unavailable-second-call

Conversation

@devag7
Copy link
Copy Markdown

@devag7 devag7 commented May 26, 2026

Fixes #433. Calls _dismiss_message_ui at the beginning of send_message to prevent stale overlays from causing composer_unavailable.

Copilot AI review requested due to automatic review settings May 26, 2026 20:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a proactive cleanup step to send_message to dismiss any lingering LinkedIn messaging overlay before navigating, along with a regression test to enforce the call order.

Changes:

  • Call _dismiss_message_ui() at the start of LinkedInExtractor.send_message() to prevent UI overlays from intercepting interactions.
  • Add an async test ensuring dismissal happens before the first navigation in send_message.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
tests/test_scraping.py Adds a regression test verifying _dismiss_message_ui() is invoked before navigation in send_message.
linkedin_mcp_server/scraping/extractor.py Ensures send_message dismisses any stale messaging overlay before navigating to the recipient profile.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/test_scraping.py Outdated
Comment on lines +4150 to +4151
assert calls[0] == "dismiss"
assert calls[1] == "nav"
Comment on lines +3170 to +3172
# Clear any floating message overlay from previous tools/calls
# that might intercept the compose box or block page interactions.
await self._dismiss_message_ui()
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 26, 2026

Greptile Summary

This PR updates send_message to clear stale LinkedIn messaging UI before composing a new message. It changes:

  • Adds a best-effort _dismiss_message_ui() call after the recipient profile page loads.
  • Keeps the existing compose navigation and confirmation flow intact.
  • Adds coverage for the expected navigation and dismissal call order.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Reviews (3): Last reviewed commit: "test(messaging): use synchronous mock si..." | Re-trigger Greptile

Comment thread linkedin_mcp_server/scraping/extractor.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] send_message: composer_unavailable on second+ call in same session, even for 1st-degree contacts

2 participants