fix(docker): set UV_PYTHON_INSTALL_DIR to avoid permission denied#468
Open
devag7 wants to merge 2 commits into
Open
fix(docker): set UV_PYTHON_INSTALL_DIR to avoid permission denied#468devag7 wants to merge 2 commits into
devag7 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the Docker build to persist uv-managed Python installations across stages by setting a custom uv Python install directory and copying it into the runtime image.
Changes:
- Set
UV_PYTHON_INSTALL_DIR=/opt/uv-pythonin the builder stage beforeuv sync. - Copy
/opt/uv-pythonfrom the builder stage into the runtime stage. - Set
UV_PYTHON_INSTALL_DIRin the runtime stage for consistency.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| WORKDIR /app | ||
| COPY pyproject.toml uv.lock README.md ./ | ||
| ENV UV_PYTHON_INSTALL_DIR=/opt/uv-python |
Comment on lines
+23
to
+24
| COPY --from=builder /opt/uv-python /opt/uv-python | ||
| ENV UV_PYTHON_INSTALL_DIR=/opt/uv-python |
Contributor
Greptile SummaryThis PR updates the Docker build so uv-managed Python is installed outside root-only paths. It changes:
Confidence Score: 5/5This looks safe to merge.
Reviews (2): Last reviewed commit: "fix(docker): define single ARG for UV_PY..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #321. Sets UV_PYTHON_INSTALL_DIR during docker build to prevent uv from using root-owned symlinks, allowing pwuser to run python.