chore: Allow only positive integers in expire #1360
Conversation
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds validation to the expire command to ensure it only accepts positive integers for the seconds parameter, aligning with Redis behavior.
- Added input validation to reject non-integer or negative values
- Throws appropriate Redis-compatible error message for invalid inputs
src/commands/expire.js
Outdated
| import { emitNotification } from '../keyspace-notifications' | ||
|
|
||
| export function expire(key, seconds) { | ||
| if (!Number.isInteger(seconds) || seconds < 0) { |
There was a problem hiding this comment.
The validation should check for seconds <= 0 instead of seconds < 0 since Redis doesn't allow zero as a valid expire value (zero would mean immediate expiration, which Redis handles differently with DEL command).
| if (!Number.isInteger(seconds) || seconds < 0) { | |
| if (!Number.isInteger(seconds) || seconds <= 0) { |
Redis only allows the use of positive integers.
romancepenguin
force-pushed
the
out-of-range-expire
branch
from
5ed1507 to
b3d1488
Compare
Some type is coming in through the string. |
2 participants
Redis only allows the use of positive integers.