Conversation
burrbull
force-pushed
the
unpull
branch
3 times, most recently
from
ef51481 to
7f171d2
Compare
Contributor
|
Looks good to me. |
burrbull
force-pushed
the
unpull
branch
4 times, most recently
from
bb05531 to
c70a8b2
Compare
Member
Author
|
I've rebased this PR. The advantage: most of APIs are much easier. Disadvantages:
|
tmehr-enqt
reviewed
Jan 20, 2026
Contributor
tmehr-enqt
left a comment
tmehr-enqt
left a comment
There was a problem hiding this comment.
I does makes it a bit cleaner. I would suggest to just remove as_push_pull_output, this is a breaking change anyways.
Member
Author
I've removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.