Add implementation of new Instance type so that I2c works (#157) #356
Annotations
48 warnings
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
casting to the same type is unnecessary (`u8` -> `u8`):
src/spi.rs#L326
warning: casting to the same type is unnecessary (`u8` -> `u8`)
--> src/spi.rs:326:23
|
326 | return Ok(self.spi.dr8().read().bits() as u8);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.spi.dr8().read().bits()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
operator precedence can trip the unwary:
src/rtc.rs#L406
warning: operator precedence can trip the unwary
--> src/rtc.rs:406:17
|
406 | let value = snd | fst << 4;
| ^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `snd | (fst << 4)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/i2c/config.rs#L74
warning: operator precedence can trip the unwary
--> src/i2c/config.rs:74:9
|
74 | psc << 28 | scldel << 20 | sdadel << 16 | sclh << 8 | scll
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(psc << 28) | (scldel << 20)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/i2c/config.rs#L74
warning: operator precedence can trip the unwary
--> src/i2c/config.rs:74:9
|
74 | psc << 28 | scldel << 20 | sdadel << 16 | sclh << 8 | scll
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `psc << 28 | scldel << 20 | (sdadel << 16)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/i2c/config.rs#L74
warning: operator precedence can trip the unwary
--> src/i2c/config.rs:74:9
|
74 | psc << 28 | scldel << 20 | sdadel << 16 | sclh << 8 | scll
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `psc << 28 | scldel << 20 | sdadel << 16 | (sclh << 8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/exti.rs#L121
warning: operator precedence can trip the unwary
--> src/exti.rs:121:44
|
121 | .modify(|r, w| unsafe { w.bits(r.bits() | 1 << ev as u8) });
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `r.bits() | (1 << ev as u8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
= note: `#[warn(clippy::precedence)]` on by default
|
|
casting to the same type is unnecessary (`u8` -> `u8`):
src/spi.rs#L326
warning: casting to the same type is unnecessary (`u8` -> `u8`)
--> src/spi.rs:326:23
|
326 | return Ok(self.spi.dr8().read().bits() as u8);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.spi.dr8().read().bits()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
operator precedence can trip the unwary:
src/rtc.rs#L406
warning: operator precedence can trip the unwary
--> src/rtc.rs:406:17
|
406 | let value = snd | fst << 4;
| ^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `snd | (fst << 4)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/i2c/config.rs#L74
warning: operator precedence can trip the unwary
--> src/i2c/config.rs:74:9
|
74 | psc << 28 | scldel << 20 | sdadel << 16 | sclh << 8 | scll
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(psc << 28) | (scldel << 20)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/i2c/config.rs#L74
warning: operator precedence can trip the unwary
--> src/i2c/config.rs:74:9
|
74 | psc << 28 | scldel << 20 | sdadel << 16 | sclh << 8 | scll
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `psc << 28 | scldel << 20 | (sdadel << 16)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/i2c/config.rs#L74
warning: operator precedence can trip the unwary
--> src/i2c/config.rs:74:9
|
74 | psc << 28 | scldel << 20 | sdadel << 16 | sclh << 8 | scll
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `psc << 28 | scldel << 20 | sdadel << 16 | (sclh << 8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/exti.rs#L130
warning: operator precedence can trip the unwary
--> src/exti.rs:130:48
|
130 | .modify(|r, w| unsafe { w.bits(r.bits() | 1 << (line - 32)) }),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `r.bits() | (1 << (line - 32))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/exti.rs#L127
warning: operator precedence can trip the unwary
--> src/exti.rs:127:48
|
127 | .modify(|r, w| unsafe { w.bits(r.bits() | 1 << line) }),
| ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `r.bits() | (1 << line)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
= note: `#[warn(clippy::precedence)]` on by default
|
|
casting to the same type is unnecessary (`u8` -> `u8`):
src/spi.rs#L326
warning: casting to the same type is unnecessary (`u8` -> `u8`)
--> src/spi.rs:326:23
|
326 | return Ok(self.spi.dr8().read().bits() as u8);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.spi.dr8().read().bits()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
operator precedence can trip the unwary:
src/rtc.rs#L406
warning: operator precedence can trip the unwary
--> src/rtc.rs:406:17
|
406 | let value = snd | fst << 4;
| ^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `snd | (fst << 4)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/i2c/config.rs#L74
warning: operator precedence can trip the unwary
--> src/i2c/config.rs:74:9
|
74 | psc << 28 | scldel << 20 | sdadel << 16 | sclh << 8 | scll
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(psc << 28) | (scldel << 20)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/i2c/config.rs#L74
warning: operator precedence can trip the unwary
--> src/i2c/config.rs:74:9
|
74 | psc << 28 | scldel << 20 | sdadel << 16 | sclh << 8 | scll
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `psc << 28 | scldel << 20 | (sdadel << 16)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/i2c/config.rs#L74
warning: operator precedence can trip the unwary
--> src/i2c/config.rs:74:9
|
74 | psc << 28 | scldel << 20 | sdadel << 16 | sclh << 8 | scll
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `psc << 28 | scldel << 20 | sdadel << 16 | (sclh << 8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/exti.rs#L121
warning: operator precedence can trip the unwary
--> src/exti.rs:121:44
|
121 | .modify(|r, w| unsafe { w.bits(r.bits() | 1 << ev as u8) });
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `r.bits() | (1 << ev as u8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
= note: `#[warn(clippy::precedence)]` on by default
|
|
casting to the same type is unnecessary (`u8` -> `u8`):
src/spi.rs#L326
warning: casting to the same type is unnecessary (`u8` -> `u8`)
--> src/spi.rs:326:23
|
326 | return Ok(self.spi.dr8().read().bits() as u8);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.spi.dr8().read().bits()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
operator precedence can trip the unwary:
src/rtc.rs#L406
warning: operator precedence can trip the unwary
--> src/rtc.rs:406:17
|
406 | let value = snd | fst << 4;
| ^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `snd | (fst << 4)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/i2c/config.rs#L74
warning: operator precedence can trip the unwary
--> src/i2c/config.rs:74:9
|
74 | psc << 28 | scldel << 20 | sdadel << 16 | sclh << 8 | scll
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(psc << 28) | (scldel << 20)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/i2c/config.rs#L74
warning: operator precedence can trip the unwary
--> src/i2c/config.rs:74:9
|
74 | psc << 28 | scldel << 20 | sdadel << 16 | sclh << 8 | scll
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `psc << 28 | scldel << 20 | (sdadel << 16)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/i2c/config.rs#L74
warning: operator precedence can trip the unwary
--> src/i2c/config.rs:74:9
|
74 | psc << 28 | scldel << 20 | sdadel << 16 | sclh << 8 | scll
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `psc << 28 | scldel << 20 | sdadel << 16 | (sclh << 8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/exti.rs#L121
warning: operator precedence can trip the unwary
--> src/exti.rs:121:44
|
121 | .modify(|r, w| unsafe { w.bits(r.bits() | 1 << ev as u8) });
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `r.bits() | (1 << ev as u8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
= note: `#[warn(clippy::precedence)]` on by default
|
|
casting to the same type is unnecessary (`u8` -> `u8`):
src/spi.rs#L326
warning: casting to the same type is unnecessary (`u8` -> `u8`)
--> src/spi.rs:326:23
|
326 | return Ok(self.spi.dr8().read().bits() as u8);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.spi.dr8().read().bits()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
operator precedence can trip the unwary:
src/rtc.rs#L406
warning: operator precedence can trip the unwary
--> src/rtc.rs:406:17
|
406 | let value = snd | fst << 4;
| ^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `snd | (fst << 4)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/i2c/config.rs#L74
warning: operator precedence can trip the unwary
--> src/i2c/config.rs:74:9
|
74 | psc << 28 | scldel << 20 | sdadel << 16 | sclh << 8 | scll
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(psc << 28) | (scldel << 20)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/i2c/config.rs#L74
warning: operator precedence can trip the unwary
--> src/i2c/config.rs:74:9
|
74 | psc << 28 | scldel << 20 | sdadel << 16 | sclh << 8 | scll
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `psc << 28 | scldel << 20 | (sdadel << 16)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/i2c/config.rs#L74
warning: operator precedence can trip the unwary
--> src/i2c/config.rs:74:9
|
74 | psc << 28 | scldel << 20 | sdadel << 16 | sclh << 8 | scll
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `psc << 28 | scldel << 20 | sdadel << 16 | (sclh << 8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/exti.rs#L121
warning: operator precedence can trip the unwary
--> src/exti.rs:121:44
|
121 | .modify(|r, w| unsafe { w.bits(r.bits() | 1 << ev as u8) });
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `r.bits() | (1 << ev as u8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
= note: `#[warn(clippy::precedence)]` on by default
|
|
casting to the same type is unnecessary (`u8` -> `u8`):
src/spi.rs#L326
warning: casting to the same type is unnecessary (`u8` -> `u8`)
--> src/spi.rs:326:23
|
326 | return Ok(self.spi.dr8().read().bits() as u8);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.spi.dr8().read().bits()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
operator precedence can trip the unwary:
src/rtc.rs#L406
warning: operator precedence can trip the unwary
--> src/rtc.rs:406:17
|
406 | let value = snd | fst << 4;
| ^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `snd | (fst << 4)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/i2c/config.rs#L74
warning: operator precedence can trip the unwary
--> src/i2c/config.rs:74:9
|
74 | psc << 28 | scldel << 20 | sdadel << 16 | sclh << 8 | scll
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(psc << 28) | (scldel << 20)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/i2c/config.rs#L74
warning: operator precedence can trip the unwary
--> src/i2c/config.rs:74:9
|
74 | psc << 28 | scldel << 20 | sdadel << 16 | sclh << 8 | scll
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `psc << 28 | scldel << 20 | (sdadel << 16)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/i2c/config.rs#L74
warning: operator precedence can trip the unwary
--> src/i2c/config.rs:74:9
|
74 | psc << 28 | scldel << 20 | sdadel << 16 | sclh << 8 | scll
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `psc << 28 | scldel << 20 | sdadel << 16 | (sclh << 8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/exti.rs#L130
warning: operator precedence can trip the unwary
--> src/exti.rs:130:48
|
130 | .modify(|r, w| unsafe { w.bits(r.bits() | 1 << (line - 32)) }),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `r.bits() | (1 << (line - 32))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/exti.rs#L127
warning: operator precedence can trip the unwary
--> src/exti.rs:127:48
|
127 | .modify(|r, w| unsafe { w.bits(r.bits() | 1 << line) }),
| ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `r.bits() | (1 << line)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
= note: `#[warn(clippy::precedence)]` on by default
|
|
casting to the same type is unnecessary (`u8` -> `u8`):
src/spi.rs#L326
warning: casting to the same type is unnecessary (`u8` -> `u8`)
--> src/spi.rs:326:23
|
326 | return Ok(self.spi.dr8().read().bits() as u8);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.spi.dr8().read().bits()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
operator precedence can trip the unwary:
src/rtc.rs#L406
warning: operator precedence can trip the unwary
--> src/rtc.rs:406:17
|
406 | let value = snd | fst << 4;
| ^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `snd | (fst << 4)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/i2c/config.rs#L74
warning: operator precedence can trip the unwary
--> src/i2c/config.rs:74:9
|
74 | psc << 28 | scldel << 20 | sdadel << 16 | sclh << 8 | scll
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(psc << 28) | (scldel << 20)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/i2c/config.rs#L74
warning: operator precedence can trip the unwary
--> src/i2c/config.rs:74:9
|
74 | psc << 28 | scldel << 20 | sdadel << 16 | sclh << 8 | scll
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `psc << 28 | scldel << 20 | (sdadel << 16)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/i2c/config.rs#L74
warning: operator precedence can trip the unwary
--> src/i2c/config.rs:74:9
|
74 | psc << 28 | scldel << 20 | sdadel << 16 | sclh << 8 | scll
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `psc << 28 | scldel << 20 | sdadel << 16 | (sclh << 8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/exti.rs#L121
warning: operator precedence can trip the unwary
--> src/exti.rs:121:44
|
121 | .modify(|r, w| unsafe { w.bits(r.bits() | 1 << ev as u8) });
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `r.bits() | (1 << ev as u8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
= note: `#[warn(clippy::precedence)]` on by default
|