DFSDM#79
Conversation
|
Reopened after it was closed by an errant bors |
|
Hi. I just implemented DFSDM, and am getting ready to test it on H7 (https://github.com/David-OConnor/stm32-hal/blob/main/src/dfsdm.rs) Which PAC fields are incorrect? Are they still incorrect? |
|
@David-OConnor neat, I'm glad someone is working on a cross-stm32 HAL (besides embassy). It seemed silly to duplicate all this work when the STM32 chips are similar enough that a lot can be reused. Looking at the register offsets and §30.8.16 of RM0433 R7, all of the field offsets except for DFSDM_CHCFG0R1 are wrong. Looks like all of the names are wrong, too and some of the fields are missing? Looking at the stm32-rs nightlies this wasn't fixed by the updated SVDs. The registers are grouped by channel. All of the different types of registers for one channel are next to each other. However in the PAC the registers are grouped by type. e.g. all of the DFSDM_CHCFGxR1 registers are one after another in memory. |
|
Fix inbound stm32-rs/stm32-rs#637 Offsets only appear to be off for H743 and H743V. Fixing reg names across H7. |

Beginning of DFSDM support. Needs work in upstream PAC crate first, register addresses from SVD are incorrect.