Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Software libraries cleanup #1186

Merged
merged 6 commits into from
Feb 20, 2025
Merged

⚠️ Software libraries cleanup #1186

merged 6 commits into from
Feb 20, 2025

Conversation

stnolting
Copy link
Owner

@stnolting stnolting commented Feb 17, 2025

  • use capital letters for all defines
  • remove obsolete functions
    • neorv32_cpu_get_clk_from_prsc() (not used at all)
    • neorv32_cpu_goto_user_mode() (too specific)
  • replace the generic neorv32_cpu_delay_ms delay function by a simpler one neorv32_aux_delay_ms (that only implements an ASM delay loop and does not rely on any specific hardware being available

* generic neorv32_cpu_delay_ms()
* neorv32_cpu_get_clk_from_prsc()
* neorv32_cpu_goto_user_mode()
that do not rely on any specific CPU hardware
@stnolting stnolting added SW Software-related cleanup Clean-up the codebase labels Feb 17, 2025
@stnolting stnolting self-assigned this Feb 17, 2025
@stnolting stnolting added the coding-style Related to the HW/SW coding style label Feb 17, 2025
@stnolting stnolting marked this pull request as ready for review February 17, 2025 21:18
@stnolting stnolting merged commit 54581c5 into main Feb 20, 2025
7 checks passed
@stnolting stnolting deleted the sw_cleanup branch February 20, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Clean-up the codebase coding-style Related to the HW/SW coding style SW Software-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant