Skip to content

feat(model): support BaseModel.load on local dirs without xturing.json#337

Merged
glennko merged 2 commits intomainfrom
issue-134-basemodel-load
Mar 3, 2026
Merged

feat(model): support BaseModel.load on local dirs without xturing.json#337
glennko merged 2 commits intomainfrom
issue-134-basemodel-load

Conversation

@glennko
Copy link
Member

@glennko glennko commented Mar 2, 2026

Summary:

  • Extends BaseModel.load to accept model_name for local directories that do not contain xturing.json.
  • Adds a clear error message when a local path is provided without xturing.json and without model_name.
  • Refactors local model creation into a small helper to avoid duplicate logic.
  • Adds unit tests for both success and error paths.

Validation:

  • PYTHONPATH=src pytest -q tests/xturing/models/test_base_model_load.py

Closes #134

@glennko glennko requested review from Vamshi-19 and yujichai March 2, 2026 04:51
@glennko glennko merged commit 9e5a3c2 into main Mar 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make xTuring config file optional or let users pass model config to BaseModel loading

2 participants