Skip to content

Add ClusterManagementAddOn resource and E2E test#172

Open
FilipB wants to merge 1 commit into
stolostron:mainfrom
FilipB:add-cmao
Open

Add ClusterManagementAddOn resource and E2E test#172
FilipB wants to merge 1 commit into
stolostron:mainfrom
FilipB:add-cmao

Conversation

@FilipB

@FilipB FilipB commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Adds ClusterManagementAddOn resource to register the addon with OCM's addon-manager. The resource is deployed via Helm and declares this as a hub-only addon with manual installation strategy.

  • Set installStrategy.type=Manual (no auto-deployment to clusters)
  • Add E2E test to verify ClusterManagementAddOn is created with correct metadata

Adds ClusterManagementAddOn resource to register the addon with OCM's
addon-manager. The resource is deployed via Helm and declares this as a
hub-only addon with manual installation strategy.

- Set installStrategy.type=Manual (no auto-deployment to clusters)
- Add E2E test to verify ClusterManagementAddOn is created with correct metadata

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Filip Brychta <fbrychta@redhat.com>
@openshift-ci

openshift-ci Bot commented Jun 25, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FilipB

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 33adf74b-fb63-464a-93b8-a0fdac3cf261

📥 Commits

Reviewing files that changed from the base of the PR and between 8b3dd53 and 62f099f.

📒 Files selected for processing (3)
  • chart/templates/clustermanagementaddon.yaml
  • test/e2e/mesh_lifecycle_test.go
  • test/e2e/suite_test.go

📝 Walkthrough

Walkthrough

Adds a ClusterManagementAddOn manifest for multicluster-mesh-addon with v1beta1 metadata, display name, description, and manual install strategy. The e2e suite registers the addon v1beta1 types in the scheme and adds a test that fetches the resource from the hub and checks those fields.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

lgtm

Suggested reviewers

  • sridhargaddam
  • jewertow
🚥 Pre-merge checks | ✅ 8
✅ Passed checks (8 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change by mentioning the new ClusterManagementAddOn resource and the E2E test.
Description check ✅ Passed The description matches the changeset and correctly explains the addon registration and manual install strategy.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Sensitive-Data-In-Logs ✅ Passed Touched files only log test-step text and cluster/namespace names; no passwords, tokens, API keys, auth headers, or secret values are logged.
Stable And Deterministic Test Names ✅ Passed The added Ginkgo titles are static strings like "Addon registration" and "should have ClusterManagementAddOn registered"; no dynamic values appear in titles.
No-Weak-Crypto ✅ Passed Changed files are YAML/test only; scans found no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto/secret-comparison code.
Container-Privileges ✅ Passed The new ClusterManagementAddOn manifest is metadata-only, and the changed files add no privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation settings.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant