This repository was archived by the owner on Jun 29, 2025. It is now read-only.
feat(ui): display time remaining for files #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this is a nice addition :) The estimated time doesn't work correctly if there are more than 3 files. Here is an example: It correctly calculates the time for the first three files that are currently uploading, but it does not account the estimated time of the other two files that are queued. |
stonith404
reviewed
May 4, 2025
| {uploading && | ||
| uploadable && | ||
| file.estimatedTimeRemaining !== undefined && ( | ||
| <Tooltip label={t("upload.filelist.time-remaining")}> |
There was a problem hiding this comment.
Is this tooltip really necessary? The column has already a label.
stonith404
suggested changes
May 4, 2025
|
I was about to check into this, but wanted to add a percentage and upload speed indicator also... might look into this later perhaps, having an estimated time is a start |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the file upload feature by adding estimated time remaining for uploads, improving the user interface, and refactoring related code for better maintainability. Key changes include introducing time estimation logic, updating the file list UI to display upload progress and time information, and adding new i18n strings for localization.
Screenshot