Feature: Backend/cache: Allow to use redis cache instead as memory #832
Conversation
There was a problem hiding this comment.
Thank you, the implementation looks good to me.
Please also add the configuration variables to the admin settings page.
You have to add the "cache" category to the Sidebar and add the name and description to the translations file.
|
Fixed |
|
Could you please enable "Maintainers are allowed to edit this pull request." in the PR? I have some minor improvements. |
This is a organization repo so I can't enable "Maintainers are allowed to edit this pull request". But i invite you as a developer so you can modify it |
JulesdeCube
changed the title
|
Putting into draft as the configuration dont seems to work. |
JulesdeCube
changed the title
|
Should be fix and ready |
|
Thanks. I still can't push to the repo even though you gave me access. Can you apply the following patches manually and commit them? 5a30fc.patch You can apply them with |
|
Hello, I apply your patchs and cleanup git history (amend and squash commits). |
Add a new section for cache attributes. Also add US translation.
|
Great, thank you :) |
2 participants
Context
I am currently deploying Pingvin on kubernetes in high availability (multiple instance of the backend and frontend).
Issue
You are using cache to store OIDC nouce.
You are ussing memory cache.
This work well when you have only one instance of the backend.
But for obvious reason it break when you more that 1 instance.
If the oidc callback arrive to a different backend that pre OIDC request the nonce will not be available and therefore the backend will throw an error because it's nonce is undefined.
PR
This PR introduce the possibility to enable/configure share Redis cache (disable by default).
Note
Thank you for this amazing project ❤️
There will also be an other related PR for PostgreSQL db backend and Kubernetes helm deployment.