chore(ruleset-bundler): rollup plugin commonjs is a dev dependency#2564
Open
w3nl wants to merge 5 commits intostoplightio:developfrom
Open
chore(ruleset-bundler): rollup plugin commonjs is a dev dependency#2564w3nl wants to merge 5 commits intostoplightio:developfrom
w3nl wants to merge 5 commits intostoplightio:developfrom
Conversation
w3nl
changed the title
w3nl
changed the title
Update rollup commonjs package to 25
P0lip
force-pushed
the
develop
branch
3 times, most recently
from
dc90b7a to
c22f408
Compare
Contributor
|
@w3nl we are unable to review this properly until tests are passing and conflicts are resolved. Please update the PR so we can move forward with this change. |
Author
|
I will check |
Contributor
|
@w3nl Gentle nudge. Can you fix the tests/linting for this. We'd love to review and get it merged in. |
Contributor
|
@w3nl Gentle reminder here. We'd love to get this in if you can get the pipeline green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2563.
Checklist
Does this PR introduce a breaking change?
For @stoplight/spectral-ruleset-bundler it is not needed to have this as a normal dependency.
Only used in a test, so not needed to set to the dependencies.
For @stoplight/spectral-cli it is used, so that package should have it as a dependency.
Additional context
Also fixes a Snyk issue of inflight
https://security.snyk.io/vuln/SNYK-JS-INFLIGHT-6095116
@stoplight/spectral-ruleset-bundler@1.5.2 › @rollup/plugin-commonjs@25.0.7 › glob@8.1.0 › inflight@1.0.6