Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): throw error if no file found to lint #2778

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

christopher-ayling
Copy link

Fixes #2675.

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes Maybe?
  • No

The cli used to show a success message if you passed a file to lint that didn't exist, leading you to believe everything was ok, when in fact no linting had been done. Now this throw's an error.

Screenshots
before:
Screenshot 2025-02-07 at 11 23 27 AM

after:

image

@christopher-ayling christopher-ayling requested a review from a team as a code owner February 7, 2025 16:25
@christopher-ayling christopher-ayling changed the title thow error if no file found to lint fix(cli): throw error if no file found to lint Feb 7, 2025
@christopher-ayling
Copy link
Author

Unable to get any harness tests to pass, even on the develop branch. Have run yarn build && yarn workspace @stoplight/spectral-cli build.binary before running yarn test.harness. still no luck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant