Skip to content

fix(rulesets): use uri-reference for openIdConnectUrl #2796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

johnf
Copy link

@johnf johnf commented Mar 18, 2025

Similar to #2652 openIdConnectURL can also be a relative reference

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@johnf johnf requested a review from a team as a code owner March 18, 2025 04:32
@mnaumanali94
Copy link
Contributor

@johnf Can you please follow the conventional commits format i.e. fix(rulesets): openIDConnectUrl type

You can either amend this commit or create a new PR.

@johnf
Copy link
Author

johnf commented Mar 19, 2025

@mnaumanali94 Sorry, I did when I saw the lint error, but forgot to push! Done now

@johnf
Copy link
Author

johnf commented Mar 19, 2025

I'm not sure why the lint is still failing, commit message seems fine now

@YOU54F
Copy link

YOU54F commented Apr 11, 2025

Hey @johnf,

It looks like the linting check applies to the PR title as well, which I assume is why this is failing, as you have already updated your commit message 👍🏾

https://github.com/stoplightio/spectral/blob/develop/CONTRIBUTING.md#linting

@johnf johnf changed the title Fix openIdConnectUrl type fix(rulesets): use uri-reference for openIdConnectUrl Apr 12, 2025
@YOU54F
Copy link

YOU54F commented Apr 15, 2025

Cheers @johnf,

I don't have the rights to kick off the CI jobs again, but if you could try and force push the commit again, as that will kick off the CI again, and pick up the updated commit message and PR title.

Once that is sorted, I can ping the core maintainer to get it merged :)

Similar to stoplightio#2652 openIdConnectURL can also be a relative reference
@johnf
Copy link
Author

johnf commented Apr 25, 2025

@YOU54F Thanks done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants