feat: ucan invocation handler #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fforbeck
force-pushed
the
feat/delegate-access-handler
branch
3 times, most recently
from
7a55163 to
3288275
Compare
fforbeck
force-pushed
the
feat/delegate-access-handler
branch
from
535e099 to
11e5f01
Compare
alanshaw
requested changes
Dec 5, 2024
Member
alanshaw
left a comment
alanshaw
left a comment
There was a problem hiding this comment.
Note: as a follow up you'll need to update reads and w3link to proxy POST /.
fforbeck
force-pushed
the
feat/delegate-access-handler
branch
from
d1a1eec to
006da33
Compare
Member
Author
Sounds good! The PR is ready for another review, @alanshaw . |
alanshaw
requested changes
Dec 6, 2024
alanshaw
approved these changes
Dec 6, 2024
Peeja
previously requested changes
Dec 6, 2024
fforbeck
force-pushed
the
feat/delegate-access-handler
branch
2 times, most recently
from
25b9df4 to
36a99a0
Compare
fforbeck
force-pushed
the
feat/delegate-access-handler
branch
from
36a99a0 to
38f0047
Compare
Peeja
reviewed
Dec 9, 2024
fforbeck
force-pushed
the
feat/delegate-access-handler
branch
from
8ecc001 to
d67fb4a
Compare
This was referenced Dec 9, 2024
Closed
fforbeck
dismissed
Peeja’s stale review
Most of the critical changes were implemented. Waiting for final review.
Member
Author
|
@Peeja, I will merge this without the |
fforbeck
force-pushed
the
feat/delegate-access-handler
branch
2 times, most recently
from
046b70e to
7e84090
Compare
fforbeck
changed the title
fforbeck
force-pushed
the
feat/delegate-access-handler
branch
from
7e84090 to
1b44871
Compare
fforbeck
force-pushed
the
feat/delegate-access-handler
branch
from
1b44871 to
b6aa238
Compare
Peeja
reviewed
Dec 11, 2024
Member
Peeja
left a comment
Peeja
left a comment
There was a problem hiding this comment.
Apologies for being slow to get back on this, it looks great!
fforbeck
pushed a commit
that referenced
this pull request
Dec 19, 2024
🤖 I have created a release *beep* *boop* --- ## [2.22.0](v2.21.0...v2.22.0) (2024-12-19) ### Features * egress client - ucanto integration ([#123](#123)) ([22bed68](22bed68)) * enable egress tracking in production env ([#135](#135)) ([ad43b62](ad43b62)) * **indexer:** probabilistic feature flag ([#136](#136)) ([dca2b35](dca2b35)) * ucan invocation handler ([#133](#133)) ([b199bfa](b199bfa)) * Use Indexing Service when feature flag is present ([#132](#132)) ([fa3f480](fa3f480)) ### Bug Fixes * **config:** staging kv bidding ([#134](#134)) ([7a523d5](7a523d5)) * **egress-client:** set nonce, expire and fix servedAt ([#130](#130)) ([b135643](b135643)) * enable open telemetry for all envs ([#131](#131)) ([c822465](c822465)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
To enable the gateway to serve content from a specific space, the space owner must delegate the
space/content/serve/*capability to the Gateway. This delegation ensures the Gateway has the authority to serve the content and log egress events accurately.This PR introduces a new handler to process POST requests to the server's root path. The handler acts as a UCAN Invocation handler, processing
access/delegateinvocations and extracting relevant delegation proofs. If a delegation proof is valid, it is stored in Cloudflare KV, allowing other handlers to retrieve and verify the proof to determine whether content should be served and egress logged.Note: It doesn't cover the token verification.
Main Changes
New Functionality
withUcanInvocationHandler.jsto processaccess/delegateinvocations:content servedelegations.FF_DELEGATIONS_STORAGE_ENABLEDif enabled, the newwithDelegationsStorage.jshandler will be used to find delegations in KV, and the existingwithDelegationsStubs.jswill be disabled.Related Issues
space/content/serveSpaces by default project-tracking#158space/content/serve/*delegations project-tracking#160