fix(middleware): use compressed format for raw requests #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
pushed a commit
that referenced
this pull request
Oct 27, 2025
🤖 I have created a release *beep* *boop* --- ## [2.31.1](v2.31.0...v2.31.1) (2025-10-27) ### Bug Fixes * **middleware:** use compressed format for raw requests ([#186](#186)) ([ef32fa9](ef32fa9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
alanshaw
reviewed
Oct 27, 2025
| const compressed = | ||
| searchParams.get('format') === 'raw' || | ||
| headers.get('Accept')?.includes('application/vnd.ipld.raw') | ||
| const locator = Locator.create({ client, compressed }) |
Member
There was a problem hiding this comment.
Presumably a block request is in the context of a DAG retrieval?
Would caching the index and location claim(s) locally help? Or is it a case of too many requests and too much churn? We're forcing a request to the indexer for every block when bitswapping over HTTP now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Use compressed format for indexer queries when serving RAW requests
Implementation
Set the compressed parameter on the locator when a raw request is detected