feat: support http3/QUIC with fallback in client #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frrist
requested review from
Peeja,
alanshaw,
hannahhoward and
volmedo
as code owners
Peeja
reviewed
Dec 17, 2025
| log.Infow("server supports http3", "url", req.URL.String()) | ||
| return resp, nil | ||
| } | ||
| log.Warnw("server doesn't support http3, using fallback (http2/1)", "error", err, "url", req.URL.String()) |
Member
There was a problem hiding this comment.
nitpick: Technically, we don't know that the server doesn't support it here, only that it failed. If there's a cleaner way to check if it's not supported (even if that's by inspecting the error), we could do that, but otherwise we can just be more precise in the wording here, so we don't confuse ourselves later, and say that http3 failed, so we're falling back to 2/1. We'd probably understand what happened anyway, but I'd rather be clear just in case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.