Open
Conversation
These aren't needed in current versions of Go. The scoping rules used to be different.
Peeja
requested review from
alanshaw,
hannahhoward and
volmedo
as code owners
alanshaw
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should give us a clearer look at what's going on when an upload isn't working right, as well as provide a means to put a custom porcelain over the top.
Currently, the JSON representations aren't particularly (human-)designed. This is largely Claude's first pass, translating the underlying event types from the bus. I don't really see anything to improve, though.
douploadhas also been updated to use--json, logging the full output to a file while displaying the latest line on the terminal.PR Dependency Tree
--jsonoutput option forupload#336 👈This tree was auto-generated by Charcoal